function checkMenu - Printable Version

The following warnings occurred:

Warning [2] Undefined variable $unreadreports - Line: 26 - File: global.php(961) : eval()'d code PHP 8.1.2-1ubuntu2.14 (Linux)

File	Line	Function
/global.php(961) : eval()'d code	26	errorHandler->error
/global.php	961	eval
/printthread.php	16	require_once

function checkMenu - Printable Version

+- UserSpice (https://userspice.com/forums)
+-- Forum: Miscellaneous (https://userspice.com/forums/forumdisplay.php?fid=28)
+--- Forum: Modifications and Hackery (https://userspice.com/forums/forumdisplay.php?fid=29)
+--- Thread: function checkMenu (/showthread.php?tid=620)

function checkMenu - faguss - 06-30-2017

I've noticed that the same query is being used multiple times which I see as a waste. The offender is

Code:
checkMenu()

function from

Code:
users\helpers\us_helpers.php

. I've modified it so that the database will be accessed only once.

function checkMenu($permission, $id) {
global $user, $access_checkMenu;
if (isset($access_checkMenu)) return $access_checkMenu;
...
$access_checkMenu=true; return true;
...
$access_checkMenu=false; return false;

Functions

Code:
checkPermission

and

Code:
hasPerm

are similar so if you use them a lot you might want to apply the same changes.