Status Update 007-008

[mudmin]

007 - Added Brandin's fixes from this post... https://userspice.com/forums/topic/statu...#post-5524

008 - Renamed adminverify.php to admin_verify.php and fixed a potential bug that allowed you to require admin_verify on admin_verify, which caused an endless loop. You should probably re-import the db. Or at least go to admin_pages to get a new page list.

[Brandin]

Mudmin,

Your fix removed requiresReAuth if the page is admin_verify?

It is not working on my end...I can't figure out why. It let me set the reAuth value on admin_page.

I can't for the life of me figure out why...

[Brandin]

Looks like the OR in our && is the issue...I don't know why but it is, use this instead:

Code:

<?php if($pageDetails->private==1 && $pageDetails->page != "users/admin_verify.php" && $pageDetails->page != "usersc/admin_verify.php") {?>

I'm working on the new admin_page anyways so I'll dump that when I'm done

[karsen]

I'd just copied over the new commit when you posted this. I haven't come across any other bugs or issues with the new features.

[Brandin]

Update updatePrivate:
http://pasted.co/97d580b9

SQL:
http://pasted.co/ce863474

Code:

admin.php

http://pasted.co/9ef5b622

Code:

admin_page.php

http://pasted.co/7dd4009f
-Added cancel button

Code:

admin_pages.php

http://pasted.co/bf1aa64c

Code:

admin_permission.php

http://pasted.co/82fe794c
-Delete redirect now displays msg
-Moved public to bottom on right sidebar
-Changed public to hyperlinks so you can quickly go to page and update it
-Added page_permission_restriction settings as below
-Added cancel button

Code:

admin_permissions.php

http://pasted.co/ce475fa6
-Successes and Errors were being cleared right before the calling, removed this
-Change permission updated from echo to successes

Adds reAuth functionality
Corrects reAuth bug on admin_verify.php page
Adds page_permission_restriction setting and functions
--If disabled (by default) normal functions occur
--If enabled, only one permission level can be assigned to a page

[Brandin]

I forgot to take out (Experimental) from the Messaging setting. I don't think we need this anymore can you take it out?

[mudmin]

Oops. I didn't prevent it from doing it on admin_page. Just admin_verify. I don't see a problem with having to reenter your pw for admin_page.

[Brandin]

No I don't either - but the || function if your if on admin_page.php to not allow it on admin_verify didn't work - it was failing. I corrected it in the above drop.

We can also remove the username option from echouser since we made echousername.

[Brandin]

Also Mudmin - can we look into deploying invisible recaptcha as an experimental thing? I would LOVE to test it out.

FYI - adding this was very simple - tested and all.

Add this under your JS call on join.php:
http://pasted.co/c8359b35

And replace your div on views/_join.php to:
http://pasted.co/84045b4d

I didn't do the login form but it would be very straight forward.

Maybe we can change the setting to be Enabled - V2, Join Only - V2, Enabled - Invisible, Join Only - Invisible, Disabled and we could include both codes? Pleaaase? lol

[karsen]

If you take the username option out of echouser it might break code for some users. I'd leave it in for backwards compatibility.