Problems with "hasPerm" function

[bladerunner]

Hi!

I'm having some problems with the hasPerm function. In a part of a page (dashboard.php), I want to show a menu only to users with permission id=2. So, I write:

<pre>

Code:

if(hasPerm([2],$user->data()->id)){
   // Some stuff
}

</pre>



Everything works fine if user "admin" is logged in ("admin" has permission of "Administrator" (id=2) and "User" (id=1)). But when user "dummy" (who has permision of "User" (id=1) only) I get this error:

Notice: Undefined variable: master_account in C:\wamp\www\true\admin\production\users\helpers\us_helpers.php on line 788
Call Stack
# Time Memory Function Location
1 0.0008 259656 {main}( ) ..\dashboard.php:0
2 0.0546 1098544 hasPerm( ) ..\dashboard.php:50

( ! ) Warning: in_array() expects parameter 2 to be array, null given in C:\wamp\www\true\admin\production\users\helpers\us_helpers.php on line 788
Call Stack
# Time Memory Function Location
1 0.0008 259656 {main}( ) ..\dashboard.php:0
2 0.0546 1098544 hasPerm( ) ..\dashboard.php:50
3 0.0821 1100296 in_array ( ) ..\us_helpers.php:788

Can anyone give some help, please? I can't understand what's happening here. Thank you!

[Brandin]

THIS IS THE ERROR I HAD BEFORE that I couldn't figure out lol

@Mudmin?

[bladerunner]

The modification of the file "us_helpers.php", adding the declaration of the variable "master_account" as global inside the function "hasPerm", has worked for me. This way:

Code:

function hasPerm($permissions, $id) {

Code:

$db = DB::getInstance();

Code:

global $user;

Code:

global $master_account;   //THIS IS THE NEW LINE

Code:

//Grant access if master user

Code:

$access = 0;

Can anyone verify if this is a correct way to fix this problem, please?

[mudmin]

I think that might be right. I never even noticed that hasPerm was the common denominator in the seemingly "random" times that has come up. THANK YOU! I will be trying it.

[Brandin]

This is why I don't use hasPerm So that's why I could never tell you why it was broke lol

[mudmin]

haha. Well as I had more permission levels, writing 10 checkmenu statements got a little clunky. This update should fix it. I'll push it out to 4.2 also.

[Brandin]

It definitely does, so once this is fixed - I will be very happy to use this!

[bladerunner]

I'm glad to hear that this solution is working properly.
Best regards.