05-26-2016, 11:54 AM
Hi,
first of all I would like to say thanks to this great work. Yesterday I watched the videos, installed UserSpice and did some first tests. Great. However, I found that it is possible to register two users with identical usernames. Thus I edited join.php and added "'unique' => 'users'," to the username array. Works fine. Later I noticed that the Number of Logins are not counting up. So I had a look into User.php and found two functions, "login" and "loginEmail", whereas the "login" Function does the counting, while the "loginEmail" Function does not. Looking into login.php I found that the Function "loginEmail" is actually used, hence no counting. Thus I changed "loginEmail" to "login" in login.php and it works like a charm.
So what I don't really understand is, why do you have these two functions there, which are quite similar? Is there a principle difference in either checking the username or the email? Was the counting within the "loginEmail" Function just forgotten or is there a reason?
Cheers,
Sebastian
first of all I would like to say thanks to this great work. Yesterday I watched the videos, installed UserSpice and did some first tests. Great. However, I found that it is possible to register two users with identical usernames. Thus I edited join.php and added "'unique' => 'users'," to the username array. Works fine. Later I noticed that the Number of Logins are not counting up. So I had a look into User.php and found two functions, "login" and "loginEmail", whereas the "login" Function does the counting, while the "loginEmail" Function does not. Looking into login.php I found that the Function "loginEmail" is actually used, hence no counting. Thus I changed "loginEmail" to "login" in login.php and it works like a charm.
So what I don't really understand is, why do you have these two functions there, which are quite similar? Is there a principle difference in either checking the username or the email? Was the counting within the "loginEmail" Function just forgotten or is there a reason?
Cheers,
Sebastian