verify.php bug and possible solution.

[plb]

Looking at the code starting at line 25 on

Code:

header.php

(included in every US page) we have this:

Code:

//check for a custom page

Code:

$currentPage = currentPage();

Code:

if(file_exists($abs_us_root.$us_url_root.'usersc/'.$currentPage)){

Code:

if(currentFolder()!= 'usersc'){

Code:

Redirect::to($us_url_root.'usersc/'.$currentPage);

Code:

}

Code:

}

Here is the definition, roughly, of

Code:

currentPage()

(I've simplified it for brevity):

Code:

return(basename($_SERVER['PHP_SELF']));

So if there is a page existing in

Code:

usersc/

then this redirection will happen automatically and it will happen to an absolute path so that there is no ambiguity about that. Choosing a consistent way to specify Redirect:too() arguments will not harm the ability to override pages with

Code:

usersc/

.

Where I sometimes have questions is with the scripts that are require_once'd (i.e., not a "page" per-se). It appears that these are require_once'd from init.php with an absolute path and no use of include_path or anything. I *think* this means that

Code:

usersc/

cannot be used to "override" scripts which are include'd or require'd. But that's a totally different question, unrelated to the Redirect.php class.