Status Update 016

[mudmin]

Goodness, Brandin was busy. His build notes will be pasted below. Note that I also merged in a few pull requests into 4.2 that I manually brought over here to 4.3 alpha.

One allows spaces in z_us_root (I guess I should say strips them out if someone accidentally puts a stray space in the array)
Another allows special characters in passwords for email servers. I don't know how that one has gone this long without causing an issue.
Finally...and I mean finally, I added PLBs git ignore to the init.php file.

We'll probably encourage command line junkies to grab updates over git. We used to have a database migration tool. Idk if I want to go back there, but it would allow better version skipping.

Thanks Brandin. Here's his notes...
UPDATES
users
admin_backup.php
-Added all loggers
-Fixed select all divs
-Changed the deletions success message, commented out original
-Added line break after delete button
admin_messages.php
-Fixed pagnation bug by adding an extra table header
-Added all loggers
-Fixed issue with deleted user gravs and names
admin_message.php
-Fixed issue with deleted user gravs and names
admin_page.php
-Added all loggers
admin_permission.php
-Added loggers
-Added success note for changing permission name
-Fixed a call for errors and successes which was overwriting the success and errors that were defined
admin_permissions.php
-Added logger
-Had to remove the call to verify if in array since there was no $permissionId
-Removed delete call and functions
-Moved submit button to top next to add permission level name
admin_user.php
-Added loggers
admin_users.php
-Removed delete function as this is legacy
-Added logger
admin_verify.php
-Added logger
admin.php
-Split register and social since they are in their own tabs
-Commented redirect calls for success messages - they were doing the same thing as they currently were anyways
-Added a recall for $settings so we have updated on post
cron_manager.php
-Added logger
-Changed active=0 bg color to #CDCDCD
cron_post.php
-Added logger
email_settings.php
-Added loggers
-Added msg on redirect
-Need to find out where the $results comes from and add success and errors results
-Will change the redirect for no test to just recall $results
forgot_password.php
-Added logger
join.php
-Added loggers
message.php
-Fixed call with deleted users gravs and names
-Added an error message and disabled attribute if the message was deleted by the other user, restricted sending in case of manual edits
messages.php
-Fixed call with deleted users gravs and names
user_settings.php
-Added loggers
views
_admin_register_settings.php
-Change call from social to register
_admin_site_settings.php
-Fixed action to be to 2 tab instead of 1
helpers
us_helpers.php
-Modified adminArchiveThread - added logger, add user_id
-Modified adminUnarchiveThread - added logger, add user_id
-Modified adminDeleteThread - added logger, add user_id
-Modified messageUser - added logger, add user_id
-Modified archiveThreads - added logger, add user_id
-Modified deleteThreads - added logger, add user_id

DELETIONS
users
create_message.php - legacy

**PLEASE ADD**
logger on login:
logger($user->data()->id,"User","User logged in.");

**SQL**
INSERT INTO

Code:

crons

(

Code:

id

,

Code:

active

,

Code:

sort

,

Code:

name

,

Code:

file

,

Code:

createdby

,

Code:

created

,

Code:

modified

) VALUES (NULL, '0', '100', 'Auto-Backup', 'backup.php', '1', CURRENT_TIMESTAMP, NULL);

[mudmin]

Brandin....do you have the sql for
notif_daylimit
amd
Notice: Undefined property: stdClass::$is_read in C:\xampp\htdocs\43\users\classes\Notification.php on line 40

[mudmin]

I also forgot to ask. What does this mean?
**PLEASE ADD**
logger on login:
logger($user->data()->id,"User","User logged in.");

[Brandin]

ALTER TABLE settings ADD notif_daylimit INT(3) NOT NULL DEFAULT 7;
ALTER TABLE notifications ADD is_archived TINYINT(1) NULL DEFAULT 0 AFTER is_read;

And the note about adding the logger to login was because I knew we had discussed changes to the login but we weren't sure what - so whatever we do, during that process, we need to add a logger to the login process which is the function I pasted there.

[karsen]

It seems like something we added is missing from the list but I can't think of anything it might be. No matter though, if something was omitted it'll still be present in the code. I don't have anything more to add to 4.3 at this time, how about you guys?

[Brandin]

Admin panel for notifications and marking notifications unread (I don't know that we need this tho).

Also where are the settings for the notifications that we added? Did I miss them? We should also add an on off setting for notifications...

[mudmin]

If I don't do stripe integrations, I think I'm good. I'm sure there are some misc things on the todo list, but overall it's complete.

I don't remember adding notification settings...but we could have crossed up our code. Do you have them on your end?

[Brandin]

I'm pretty sure Karsen did something to change the default notification timeout...I don't have it on my end but I'm pretty sure he did

[karsen]

Oops, forgot to give you that code for admin.php. If I can get added as a collaborator I'll figure out these GitHub shenanigans!

Code:

admin.php

: https://pastebin.com/dfYxP5Ct

Code:

views/_admin_site_settings.php

: https://pastebin.com/n9Q6Vta8

[Brandin]

Gosh Karsen

What editor do you use?

I'm using SourceTree for my gits (it works great!!!) and Atom (I think mudmin uses this too) - once you get your git setup you can also push and pull using Atom which is cool, but I prefer to use SourceTree.