09-19-2016, 07:15 PM
Issues listed in descending order of priority - more important, in my view, at the top:
- Changes to DB.php to allow for more than a single condition in WHERE - absolutely necessary, IMHO, to make the query functions usable - http://pastebin.com/0rhnxLB7
- Changes to Redirect.php to allow passing ?foo=bar&a=b type of arguments while still fixing the absolute/relative business. It was driving me crazy (I develop in different directories and US redirects kept getting mixed up) until I made this change - http://pastebin.com/yvSx71U1
- Lots of times I want stuff modifiable in init.php Config::get() rather than having to copy stuff into usersc/ and modify the view or be stuck with a modified includes/ or helpers/ script that I have to keep merging. In general I think it's a good idea, whenever deciding on a default value, to put a little conditional to allow users to override that default via config. I know this isn't specific, but it's something I recommend to your attention. (example is just recently redirecting to a given page after logging in - why have a whole custom_login_script.php when you could just put a value in the Config...)
- Changes in header.php to allow custom CSS for a given page (2 ways provided - one might suffice) - http://pastebin.com/fFWLKvmt